# Use real topography data with GeophysicalModelGenerator #63

vincmarks · 2025-05-26T12:38:18Z

Changes

Added example script geo_data.jl that shows how to use GeophysicalModelGenerator to load real topography and use it for simulations in TrixiBottomTopography.

Testing

Code runs successfully locally
All simulations produce expected results

Notes

Ci.yml: Success
FormatCheck.yml: Failure
Documenter.yml: Failure
Looking for feedback on:
- how to fix the errors to also pass FormatCheck.yml and Documenter.yml

… geht jetzt

…tError if you don't choose your gridsizes the right way

…oMakie

…, convert_geo_1d, convert_geo_2d to create arbitrary topography data and make it accessible to TrixiBottomTopography.

…f P4est mesh

vincmarks · 2025-08-07T13:46:36Z

Changes

Added the functions geo_topo_impression and create_topography_data to generate arbitrary topography data. For this, the functionalities of GeophysicalModelGenerator are used.
Added the functions convert_geo_1d and convert_geo_2d to convert the topography data (from geo_topo_impression and create_topography_data) into the format required by TrixiBottomTopography.
Added the file create_convert_data_geo.jl in which the functions convert_geo_1d and convert_geo_2d are used to generate the topography data (geo.xyz) and convert it properly (rhine_data_1d_20_x_geo.txt, rhine_data_1d_20_y_geo.txt, rhine_data_2d_20_geo.txt). There is also a Markdown file create_convert_geo_data.md in which the used functions are explained.
Added the files trixishallowwater_dam_break_1D_geo_data.jl and trixishallowwater_dam_break_2D_geo_data.jl which consider a dam break scenario. These files essentially replicate trixishallowwater_dam_break_1D and trixishallowwater_dam_break_2D but now with the topography data generated from create_convert_data_geo.jl. One difference is the use of a different mesh type due to the rectangular shape of the domain in the trixishallowwater_dam_break_2D_geo_data.jl file. Here, a P4est mesh is used and the solution is visualized in ParaView.

ranocha

Thanks! I will take a look at this. Could you please restore files that do not need to change in this PR? For example, the .JuliaFormatter.toml file is deleted and some random files have been reformatted but not changed otherwise.

ranocha · 2025-08-26T10:09:48Z

docs/src/create_convert_geo_data.md

@@ -0,0 +1,214 @@
+# Create and convert real topography data
+In this section, it is explained how to get real topography data using GeophysicalModelGenerator.jl and make it accessible to TrixiBottomTopography. The necessary structure of the data for TrixiBottomTopography is explained in the `docs/src/conversion.md` file. In the file `docs/src/trixishallowwater_jl_geo_data_examples`, it is then explained how to properly run simulations with this data. In the following, we will consider the example file `create_convert_data_geo.jl`.


Could you please add links to Julia packages and add the .jl part to them, e.g.,

Suggested change

In this section, it is explained how to get real topography data using GeophysicalModelGenerator.jl and make it accessible to TrixiBottomTopography. The necessary structure of the data for TrixiBottomTopography is explained in the `docs/src/conversion.md` file. In the file `docs/src/trixishallowwater_jl_geo_data_examples`, it is then explained how to properly run simulations with this data. In the following, we will consider the example file `create_convert_data_geo.jl`.

In this section, it is explained how to get real topography data using [GeophysicalModelGenerator.jl](https://github.com/JuliaGeodynamics/GeophysicalModelGenerator.jl) and make it accessible to [TrixiBottomTopography.jl](https://github.com/trixi-framework/TrixiBottomTopography.jl).

The necessary structure of the data for [TrixiBottomTopography.jl](https://github.com/trixi-framework/TrixiBottomTopography.jl) is explained in the `docs/src/conversion.md` file. In the file `docs/src/trixishallowwater_jl_geo_data_examples`, it is then explained how to properly run simulations with this data. In the following, we will consider the example file `create_convert_data_geo.jl`.

Could you please also update references to other doc files to real Documenter.jl/Markdown references that will be rendered as HTML links in the online docs?

ranocha · 2025-08-26T10:11:59Z

docs/src/create_convert_geo_data.md

+```julia
+# Get a first impression of the topography data
+Topo, p, Topo_Cart = geo_topo_impression(
+    resolution="@earth_relief_01s", 
+    lon_min=6.963880, 
+    lon_max=6.978499, 
+    lat_min=50.947861, 
+    lat_max=50.957095
+)
+```


If the examples you demonstrate here do not run forever, could you please turn them into Documenter.jl named @example blocks so that they will be executed when building the online docs to ensure that everything still works?

ranocha · 2025-08-26T10:14:53Z

examples/data/geo.xyz

Is it necessary to load such huge files into the git repository?

vincmarks added 30 commits April 28, 2025 15:44

first geo_data datei

87de31d

first load of topographic data + paraview file for this topographic data

63460d2

add: convert2CartData

92773d3

trying to get somewhere

d172728

Merge remote-tracking branch 'upstream/main'

2d18e13

übergabe von geophysicalmodelgenerator.jl an trixibottomtopography.jl…

91d023e

… geht jetzt

produced txt files with modelgenerator

b50a36d

built in a try-catch function to obtain early if you run into a nexac…

67d5de0

…tError if you don't choose your gridsizes the right way

text hinzu

77cd2c9

text hinzugefügt

db231b9

updated data

65164d8

formattiert

f5f4b52

trying to format better

2cae6c4

try to format

e1a93bc

smoothing_factor !=0-> then it works

5bd9e78

deletet cairomakie because of error + formatting

1301c2c

formatting

3396908

do the examples with modelgenerator

ebcf37d

try to compare the example and the data

a57987c

automatic changes

7c2dfc6

converting the data so everything works properly

a63dae6

converting data

d65a6fb

praparations PR

c1bb850

Merge remote-tracking branch 'upstream/main'

6404954

preparation pr

8f1a5cd

formatting

c4f6506

instantiate auskommentieren

a522fe5

chairomakie auskommentiert

02522cd

new chairomakie version

87b30ac

editing

af361f4

vincmarks added 26 commits June 23, 2025 10:52

added GMT in compat

09910b0

using GMT as weak deps

fc70b72

updated version of GeophysicalModelGenerator, GeometryBasics and Cair…

be312d7

…oMakie

explaining the functions: geo_topo_impression, create_topography_data…

2d66b92

…, convert_geo_1d, convert_geo_2d to create arbitrary topography data and make it accessible to TrixiBottomTopography.

not using GMT and GeophysicalModelGenerator as weakdeps anymore

0431f15

using Trixi2Vtk

85a3cca

fixed typo

c4853cb

explain how to use the created topography data for simulations.

aac3526

deleting unnecessary file

4134d81

fixed typo

31c4b74

formatted and changed name of the animation

2a1b704

using Trixi2Vtk to visualize the animation in Paraview due to using o…

e57b43f

…f P4est mesh

Merge remote-tracking branch 'upstream/main'

90334ee

formatted

7eae1bd

changing paths

47c94f2

changing paths

b56a75c

changed pathname

1a91793

allow the geo.xyz file

ef3a8ef

using Dataframes

eac45b8

file of the topography

4c3334d

correcting missing data and variable-scoping

ef01553

deleting unnecessary stuff

8760c4c

reformulating some stuff

bbf567a

fixed typo

c7a8110

corrected errors detected by Spell Check

282cc75

changed @example blocks with julia

8c4f131

vincmarks marked this pull request as ready for review August 7, 2025 13:46

ranocha requested changes Aug 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

# Use real topography data with GeophysicalModelGenerator #63

# Use real topography data with GeophysicalModelGenerator #63

Uh oh!

vincmarks commented May 26, 2025

Uh oh!

vincmarks commented Aug 7, 2025

Uh oh!

ranocha left a comment

Uh oh!

ranocha Aug 26, 2025

Uh oh!

ranocha Aug 26, 2025

Uh oh!

ranocha Aug 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,214 @@
		# Create and convert real topography data
		In this section, it is explained how to get real topography data using GeophysicalModelGenerator.jl and make it accessible to TrixiBottomTopography. The necessary structure of the data for TrixiBottomTopography is explained in the `docs/src/conversion.md` file. In the file `docs/src/trixishallowwater_jl_geo_data_examples`, it is then explained how to properly run simulations with this data. In the following, we will consider the example file `create_convert_data_geo.jl`.

	In this section, it is explained how to get real topography data using GeophysicalModelGenerator.jl and make it accessible to TrixiBottomTopography. The necessary structure of the data for TrixiBottomTopography is explained in the `docs/src/conversion.md` file. In the file `docs/src/trixishallowwater_jl_geo_data_examples`, it is then explained how to properly run simulations with this data. In the following, we will consider the example file `create_convert_data_geo.jl`.
	In this section, it is explained how to get real topography data using [GeophysicalModelGenerator.jl](https://github.com/JuliaGeodynamics/GeophysicalModelGenerator.jl) and make it accessible to [TrixiBottomTopography.jl](https://github.com/trixi-framework/TrixiBottomTopography.jl).
	The necessary structure of the data for [TrixiBottomTopography.jl](https://github.com/trixi-framework/TrixiBottomTopography.jl) is explained in the `docs/src/conversion.md` file. In the file `docs/src/trixishallowwater_jl_geo_data_examples`, it is then explained how to properly run simulations with this data. In the following, we will consider the example file `create_convert_data_geo.jl`.

# Use real topography data with GeophysicalModelGenerator #63

Are you sure you want to change the base?

# Use real topography data with GeophysicalModelGenerator #63

Uh oh!

Conversation

vincmarks commented May 26, 2025

Changes

Testing

Notes

Uh oh!

vincmarks commented Aug 7, 2025

Changes

Uh oh!

ranocha left a comment

Choose a reason for hiding this comment

Uh oh!

ranocha Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

ranocha Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

ranocha Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants